Difference between revisions of "Talk:Geode Crusher"
Margotbean (talk | contribs) |
|||
| Line 4: | Line 4: | ||
Leaving my findings here. For crushers, the code at <samp>Object::performObjectDropInAction</samp> (within the branch of the only occurrence of <samp>Geode Crusher</samp> in this file) increments <samp>Game1.stats.GeodesCracked</samp> ''after'' calling <samp>Utility.getTreasureFromGeode</samp>, while Clint's code <samp>GeodeMenu::update</samp> increments the same stat long before calling <samp>Utility.getTreasureFromGeode</samp>. There's no explicit offset code, but the off-by-one difference is due to how the logic is laid out in two different code paths. I'd probably call it a glitch, though. [[User:IBugOne|IBugOne]] ([[User talk:IBugOne|talk]]) 17:48, 2 January 2023 (UTC) | Leaving my findings here. For crushers, the code at <samp>Object::performObjectDropInAction</samp> (within the branch of the only occurrence of <samp>Geode Crusher</samp> in this file) increments <samp>Game1.stats.GeodesCracked</samp> ''after'' calling <samp>Utility.getTreasureFromGeode</samp>, while Clint's code <samp>GeodeMenu::update</samp> increments the same stat long before calling <samp>Utility.getTreasureFromGeode</samp>. There's no explicit offset code, but the off-by-one difference is due to how the logic is laid out in two different code paths. I'd probably call it a glitch, though. [[User:IBugOne|IBugOne]] ([[User talk:IBugOne|talk]]) 17:48, 2 January 2023 (UTC) | ||
:Thank you very very much for the research!! Knowing CA's coding style, I'd tend to agree. I'll change the heading back. [[User:Margotbean|margotbean]] ([[User talk:Margotbean|talk]]) 18:45, 2 January 2023 (UTC) | :Thank you very very much for the research!! Knowing CA's coding style, I'd tend to agree. I'll change the heading back. [[User:Margotbean|margotbean]] ([[User talk:Margotbean|talk]]) 18:45, 2 January 2023 (UTC) | ||
| + | |||
| + | This page should be updated; as of update 1.6, Geode Crushers no longer require coal to function, and the description has been changed to match this. Notifying as I am a new account, and this would require large-scale editing of the page. [[User:ClockwiseSymphony|ClockwiseSymphony]] ([[User talk:ClockwiseSymphony|talk]]) 02:42, 20 March 2024 (UTC) | ||
Revision as of 02:42, 20 March 2024
| This talk page is for discussing Geode Crusher. | |
|---|---|
|
|
Glitch or Trivia?
Leaving my findings here. For crushers, the code at Object::performObjectDropInAction (within the branch of the only occurrence of Geode Crusher in this file) increments Game1.stats.GeodesCracked after calling Utility.getTreasureFromGeode, while Clint's code GeodeMenu::update increments the same stat long before calling Utility.getTreasureFromGeode. There's no explicit offset code, but the off-by-one difference is due to how the logic is laid out in two different code paths. I'd probably call it a glitch, though. IBugOne (talk) 17:48, 2 January 2023 (UTC)
- Thank you very very much for the research!! Knowing CA's coding style, I'd tend to agree. I'll change the heading back. margotbean (talk) 18:45, 2 January 2023 (UTC)
This page should be updated; as of update 1.6, Geode Crushers no longer require coal to function, and the description has been changed to match this. Notifying as I am a new account, and this would require large-scale editing of the page. ClockwiseSymphony (talk) 02:42, 20 March 2024 (UTC)